On 6/10/25 18:52, John Levon wrote:
On Tue, Jun 10, 2025 at 11:57:00AM +0200, Cédric Le Goater wrote:
@@ -529,6 +531,8 @@ _meson_option_parse() {
--disable-vdi) printf "%s" -Dvdi=disabled ;;
--enable-vduse-blk-export) printf "%s" -Dvduse_blk_export=enabled ;;
--disable-vduse-blk-export) printf "%s" -Dvduse_blk_export=disabled ;;
+ --enable-vfio-user-client) printf "%s" -Dvfio_user_client=enabled ;;
+ --disable-vfio-user-client) printf "%s" -Dvfio_user_client=disabled ;;
--enable-vfio-user-server) printf "%s" -Dvfio_user_server=enabled ;;
--disable-vfio-user-server) printf "%s" -Dvfio_user_server=disabled ;;
--enable-vhdx) printf "%s" -Dvhdx=enabled ;;
can't we simply have a CONFIG option and select the device on platforms
supporting it ?
You mean always build vfio-user client rather than optionally? Why would it be
different from other optional components?
why would it be optional ? I don't see any dependency for vfio-user-client.
vfio-user-server depends on libvfio-user [1]. Not vfio-user-client.
Should it ?
Does this mean we are abandoning libvfio-user ? Sorry I am not familiar with
this framework.
AFAIK all platforms (at least in theory) would support it.
So what would be the reason for not compiling it ? It is not different
from VFIO AFAICT.
Thanks,
C.
[1] https://gitlab.com/qemu-project/libvfio-user
