On Sun, Jun 8, 2025 at 1:26 AM Akihiko Odaki <akihiko.od...@daynix.com> wrote:
> On 2025/06/07 5:50, John Snow wrote: > > In advance of actually bumping the build system requirements for Sphinx, > > bump the version used for the static analysis tests. Update the minimum > > requirements accordingly. > > > > This changes the test environment without actually changing the build > > requirements, and no extra changes are needed for the tests to continue > > passing. > > > > Signed-off-by: John Snow <js...@redhat.com> > > Reviewed-by: Akihiko Odaki <od...@rsg.ci.i.u-tokyo.ac.jp> > > I didn't notice these files. Perhaps they are better to be documented > with pythondeps.toml. > You didn't miss them, they were added after you submitted your patch :) The python tests checking anything to do with sphinx are very recent. The relationship between pythondeps.toml and python/setup.cfg and python/tests/minreqs.txt is still tenuous, but I'll keep in mind that we may need to better document the relationships. (Sphinx and its dependencies are installed only for the sake of pylint and mypy to check docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py, as those packages need to be present in order for the static type analysis to work fully. We don't actually *run* Sphinx from those tests, we just use them as "headers", effectively.) Thanks again, --js > > Regards, > Akihiko Odaki > >
