On Wed, May 28, 2025 at 04:30:55PM +0200, Magnus Kulke wrote: > On Tue, May 20, 2025 at 10:22:27PM +0000, Wei Liu wrote: > > On Tue, May 20, 2025 at 01:30:11PM +0200, Magnus Kulke wrote: > > > + /* > > > + * TODO: support asserting an interrupt using interrup_bitmap > > > + * it should be possible if we use the vm_fd > > > + */ > > > + > > > > Why is there a need to assert an interrupt here? > > > > The comment has been carried over from the mshv-ioctl crate: > > https://github.com/rust-vmm/mshv/blob/main/mshv-ioctls/src/ioctls/vcpu.rs#L778 > > I was wondering whether we can/want to set the bitmap here, since we do > have access to the vm_fd, but I didn't follow up on that yet.
In the code snippet you quoted, an error is returned if the bitmap is not empty. Please at least print a warning if the bitmap is not empty to catch any issues. Debugging lost interrupts is hard enough as it is. CC the Rust-VMM code co-owners for awareness. Thanks, Wei.
