On 6/6/25 05:20, Shaoqin Huang wrote:
Hi, guys
Thanks for all of your suggestions.
On 6/5/25 11:11 PM, Philippe Mathieu-Daudé wrote:
On 5/6/25 14:21, Gerd Hoffmann wrote:
Hi,
Now the ramfb will load the vgabios-ramfb.bin unconditionally, but
only
the x86 need the vgabios-ramfb.bin, this can cause that when use the
release package on arm64 it can't find the vgabios-ramfb.bin.
Simpler to directly pass the ROM path instead of using a boolean,
so board (or CLI) could pass path to non-x86 rom.
The rom is loaded into a fw_cfg file which only seabios will look at.
So this rom logic is x86-specific.
edk2 ships an EFI driver for ramfb, that is how ramfb is used on !x86
platforms today, and I don't expect that to change.
IMHO a bool is perfectly fine here, I don't think we will ever need the
flexibility to specify some other rom here.
Understood, better then! Maybe name the boolean "use_legacy_x86_rom" and
add a comment explaining EFI driver is expected on !x86?
I think the "use_legacy_x86_rom" is good, I will change the name to it.
And I will add a comment to explain it.
Maybe even better could be to only register (expose) this property for
x86 machines. We'll discuss that on your v2, no need to hold.
