On Thu, Jun 5, 2025 at 4:36 AM Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Thu, Jun 05, 2025 at 08:33:44AM +0200, Markus Armbruster wrote: > > John Snow <js...@redhat.com> writes: > > > > [...] > > > > > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > > > new file mode 100755 > > > index 00000000000..2211b6c7f41 > > > --- /dev/null > > > +++ b/python/tests/qapi-flake8.sh > > > @@ -0,0 +1,6 @@ > > > +#!/bin/sh -e > > > +# SPDX-License-Identifier: LGPL-2.1-or-later > > > > Why not GPL-2.0-or-later? > > Indeed, checkpatch.pl should be warning about this choice, and requesting > that it be explained in the commit message. > Ah. Well, it's what I have defaulted to for the standalone QMP library, but I realize now this code isn't anything I will be bothering to sync over to that library, so GPL is fine. I will adjust it for my pull request. (And I'll fix the squashed commit message I forgot about! Oops!)
