On Fri, May 30, 2025 at 10:02:52AM +0200, Paolo Bonzini wrote: > Date: Fri, 30 May 2025 10:02:52 +0200 > From: Paolo Bonzini <pbonz...@redhat.com> > Subject: [PATCH v2 00/14] rust: bindings for Error > X-Mailer: git-send-email 2.49.0 > > As explained for v1, the impetus for this series is to remove BqlCell<> > from HPETState::num_timers. However, it's also an important step for QAPI: > error propagation is pretty central for example to QMP, and the series > is also a first example of two-way conversion between C and native-Rust > structs (i.e. not using bindgen-generated structs or their opaque wrappers). > > As an aside, support for NUL-terminated file is now scheduled for > inclusion in Rust as "panic::Location::file_with_nul()", but it will be > quite a while before QEMU can use it. For more information, see > https://github.com/rust-lang/rust/issues/141727.
Apart from Markus's comments, the rest of the code (the specific implementation of error binding) looks great to me. The interaction with Foreign crate is quite insightful. I'll go through other patches on the rust-next branch. Thanks, Zhao
