On 6/3/25 09:11, Song Gao wrote:
on qemu we got an aborted error
**
ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value:
code should not be reached
Bail out!
ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value:
code should not be reached
Aborted (core dumped)
bu on 3A600/3A5000 we got a "Illegal instruction" error.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2971
Signed-off-by: Song Gao <gaos...@loongson.cn>
---
target/loongarch/tcg/insn_trans/trans_vec.c.inc | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/target/loongarch/tcg/insn_trans/trans_vec.c.inc
b/target/loongarch/tcg/insn_trans/trans_vec.c.inc
index dff92772ad..f8ff4fa18c 100644
--- a/target/loongarch/tcg/insn_trans/trans_vec.c.inc
+++ b/target/loongarch/tcg/insn_trans/trans_vec.c.inc
@@ -3465,7 +3465,7 @@ TRANS(xvmsknz_b, LASX, gen_xx, gen_helper_vmsknz_b)
static uint64_t vldi_get_value(DisasContext *ctx, uint32_t imm)
{
int mode;
- uint64_t data, t;
+ uint64_t data = 0, t;
/*
* imm bit [11:8] is mode, mode value is 0-12.
@@ -3569,18 +3569,24 @@ static uint64_t vldi_get_value(DisasContext *ctx,
uint32_t imm)
data = (t1 << 54) | (t0 << 48);
}
break;
- default:
- generate_exception(ctx, EXCCODE_INE);
- g_assert_not_reached();
Drop the generate_exception, but keep the assert.
It really is no longer reachable because of check_vldi_mode().
}
return data;
}
+static bool check_vldi_mode(arg_vldi *a)
+{
+ return (a->imm >>8 & 0xf) > 12 ? false : true;
Never use ?: with true/false. Just use the proper boolean expression:
return ((a->imm >> 8) & 0xf) <= 12;
r~
