Am 30.05.25 um 17:11 schrieb Fiona Ebner: > By using the appropriate variants bdrv_set_backing_hd_drained() and > bdrv_try_change_aio_context_locked(), there only needs to be a single > drained and write-locked section in external_snapshot_abort(). > > Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> > --- > > The assumption in the added code comment about the reference is AFAIU > it. Is this correct? > > And unrelated, but I'm wondering, isn't this dead code? It's only > executed if state->overlay_appended is set, which happens at the very > end of external_snapshot_action(). How can the transaction still be > aborted after that?
Of course, the point is that there can be multiple actions in a transaction :) I had tunnel vision on Friday. Best Regards, Fiona
