On 13.05.2025 18:54, Kevin Wolf wrote:
Am 27.09.2024 um 08:11 hat Michael Tokarev geschrieben:
Add missing long options and --help output.
...
+" --image-opts\n"
+" indicates that FILENAME is a complete image specification\n"
+" instead of a file name (incompatible with --format)\n"
The man page has:
Indicates that the source *FILENAME* parameter is to be interpreted as a
full option string, not a plain filename. This parameter is mutually
exclusive with the *-f* parameter.
A possible adaptation for qemu-img check specially:
indicates that FILENAME is a full option string, not a plain filename
(incompatible with --format)
What I ended up now is:
--image-opts
treat FILE as an option string (key=value,..), not a file name
(incompatible with -f|--format)
Note I used short "FILE" everywhere, while in the manpage we see
longer FILENAME - my plan is to get the manpage to use the same
FILE too, in the next step (I can probably do it together with
each individual commit in this series too).
Maybe it's better to use IMAGE instead of FILE, because:
FILE
name of the image file, or an option string (key=value,..)
with --image-opts, to operate on
(this is another common idiom I used in all the changes).
+" --object OBJDEF\n"
+" QEMU user-creatable object (eg encryption key)\n"
"e.g."
it is also different from the manpage (where OBJECTDEF is used).
I ended up with just:
--object OBJDEF
defines QEMU user-creatable object
Since --object can be used with any command, maybe it's a good
idea to have it in common options string, before a subcommand.
Thanks,
/mjt
