On 28/05/2025 10.30, Thomas Huth wrote:
On 27/05/2025 19.20, Thomas Huth wrote:
On 12/05/2025 10.39, Philippe Mathieu-Daudé wrote:
The "fallback" property was only used by the hw_compat_2_5[] array,
as 'fallback=144'. We removed all machines using that array, lets
remove ISA floppy drive 'fallback' property, manually setting the
default value in isabus_fdc_realize().
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Zhao Liu <zhao1....@intel.com>
---
hw/block/fdc-isa.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
FWIW, this needs a fixup for iotest 172:
https://gitlab.com/thuth/qemu/-/jobs/10166450223#L466
FYI, since I was testing this series anyway, I'll fix up this patch
...
and I will queue this series (without the "Remove X86CPU::check_cpuid field"
patch as mentioned by Xiaoyao Li), unless Paolo or another x86 maintainer
wants to do this instead (please let me know!).
Hmm, looking at this twice, hw/block/fdc-sysbus.c has a "fallback" property,
too, and there are people out there who set this property manually, e.g.:
https://github.com/mariuz/linux-0.01/issues/4#issuecomment-974768898
So it seems like this property is meant as a config knob for the user,
indeed, not just an internal one. I'll drop this patch for now.
Thomas
