On Tue, May 27, 2025 at 01:56:52PM -0700, Steve Sistare wrote: > If vfio_realize fails after vfio_device_attach, it should call > vfio_device_detach during error recovery. If it fails after > vfio_device_get_name, it should free vbasedev->name. If it fails > after vfio_pci_config_setup, it should free vdev->msix. > > To fix all, call vfio_pci_put_device(). > > Signed-off-by: Steve Sistare <steven.sist...@oracle.com> > --- > hw/vfio/pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index a1bfdfe..7d3b9ff 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3296,6 +3296,7 @@ out_teardown: > vfio_bars_exit(vdev); > error: > error_prepend(errp, VFIO_MSG_PREFIX, vbasedev->name); > + vfio_pci_put_device(vdev); > } > > static void vfio_instance_finalize(Object *obj)
Reviewed-by: John Levon <john.le...@nutanix.com>
