On 26/5/25 15:18, BALATON Zoltan wrote:
On Mon, 26 May 2025, Philippe Mathieu-Daudé wrote:
Only add default devices checking defaults_enabled().
Remove the unused usb_disabled field in MachineState.
At least for Mac machines this may be more complex. I think there is a -
usb switch to enable/disable USB independently of defaults and due to
some bugs some MacOS versions may need this to boot so maybe it's used.
If the user asks -usb off, we shouldn't re-enable it in the shadow.
If a configuration isn't usable, we have to report a configuration
error, possibly providing hints about what should be fixed.
Regards,
BALATON Zoltan
Based-on: <20250526112346.48744-1-phi...@linaro.org>
"hw/ppc: Fix --without-default-devices build"
Philippe Mathieu-Daudé (3):
hw/ppc/spapr: Only create default devices when requested
hw/ppc/mac_newworld: Only create default devices when requested
hw/boards: Remove MachineState::usb_disabled field
include/hw/boards.h | 1 -
hw/core/machine.c | 1 -
hw/ppc/mac_newworld.c | 3 +--
hw/ppc/spapr.c | 3 +--
4 files changed, 2 insertions(+), 6 deletions(-)
