Hi Cédric,
> -----Original Message-----
> From: Cédric Le Goater <c...@redhat.com>
> Sent: Wednesday, May 14, 2025 9:28 PM
> To: Steven Lee <steven_...@aspeedtech.com>; Peter Maydell
> <peter.mayd...@linaro.org>; Troy Lee <leet...@gmail.com>; Jamin Lin
> <jamin_...@aspeedtech.com>; Andrew Jeffery
> <and...@codeconstruct.com.au>; Joel Stanley <j...@jms.id.au>; open
> list:ASPEED BMCs <qemu-...@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_...@aspeedtech.com>; long...@lenovo.com; Yunlin Tang
> <yunlin.t...@aspeedtech.com>
> Subject: Re: [PATCH v2 2/5] hw/arm/aspeed_ast27x0: Fix unimplemented
> region overlap with vbootrom
>
> On 5/14/25 11:03, Steven Lee wrote:
> > The unimplemented memory region overlaps with the VBootROM address
> > range, causing incorrect memory layout and potential behavior issues.
> >
> > This patch adjusts the size and start address of the unimplemented
> > region to avoid collision. The IO memory region (ASPEED_DEV_IOMEM) is
> > now moved to 0x20000 to reserve space for VBootROM at 0x0.
> >
> > Signed-off-by: Steven Lee <steven_...@aspeedtech.com>
>
> You didn't reply to the question I asked on the v1 series.
> How useful is this ASPEED_DEV_IOMEM region ?
>
Sorry for not replying to your question about this patch in the v1 series
earlier.
Somehow our mail server mistakenly flagged that particular message as spam, so
I missed it initially.
Regarding the ASPEED_DEV_IOMEM region, I checked the datasheet, and you're
right, no devices are mapping registers in this window.
Since it's unused, there's no need to map it in an unimplemented region. I will
drop this patch in v3 patch series.
Regards,
Steven
>
> > ---
> > hw/arm/aspeed_ast27x0.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index
> > 1974a25766..bb61c30cf4 100644
> > --- a/hw/arm/aspeed_ast27x0.c
> > +++ b/hw/arm/aspeed_ast27x0.c
> > @@ -23,14 +23,14 @@
> > #include "qobject/qlist.h"
> > #include "qemu/log.h"
> >
> > -#define AST2700_SOC_IO_SIZE 0x01000000
> > +#define AST2700_SOC_IO_SIZE 0x00FE0000
> > #define AST2700_SOC_IOMEM_SIZE 0x01000000
> > #define AST2700_SOC_DPMCU_SIZE 0x00040000
> > #define AST2700_SOC_LTPI_SIZE 0x01000000
> >
> > static const hwaddr aspeed_soc_ast2700_memmap[] = {
> > - [ASPEED_DEV_IOMEM] = 0x00000000,
> > [ASPEED_DEV_VBOOTROM] = 0x00000000,
> > + [ASPEED_DEV_IOMEM] = 0x00020000,
> > [ASPEED_DEV_SRAM] = 0x10000000,
> > [ASPEED_DEV_DPMCU] = 0x11000000,
> > [ASPEED_DEV_IOMEM0] = 0x12000000,
