On Wed, May 14, 2025 at 01:25:05PM +0000, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > "info migrate" is the command people would frequently use to query > > migration status. We may not want it to dump global configurations because > > dumping the same things over and over won't help. > > > > The globals are just more suitable for a parameter dump instead. Hence > > move it over. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > I think this is a *little* odd, since 'info migrate_parameters' > is a list of the things you can set with 'migrate_set_parameters' > Perhaps it would be better to add it under the 'info migrate -a' option > you add in the next patch?
Makes sense. > > However, one other thing, the globals stuff prints a > 'globals:' at the start, but doesn't print anything at the end, > so if you make this change, you end up with out being able to tell > where the globals end and the parameters start, so maybe a > 'parameters:' after it? I'll drop this patch, but only dump the globals if "-a" is specified in the next patch. Thanks! -- Peter Xu
