Looks good.
Reviewed-by: Caleb Schlossin <cal...@linux.ibm.com>
On 5/11/25 10:10 PM, Nicholas Piggin wrote:
> Report access size in XIVE TM operation error logs.
>
> Signed-off-by: Nicholas Piggin <npig...@gmail.com>
> ---
> hw/intc/xive.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/intc/xive.c b/hw/intc/xive.c
> index 3eb28c2265..80b07a0afe 100644
> --- a/hw/intc/xive.c
> +++ b/hw/intc/xive.c
> @@ -326,7 +326,7 @@ static void xive_tm_raw_write(XiveTCTX *tctx, hwaddr
> offset, uint64_t value,
> */
> if (size < 4 || !mask || ring_offset == TM_QW0_USER) {
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: invalid write access at TIMA
> @%"
> - HWADDR_PRIx"\n", offset);
> + HWADDR_PRIx" size %d\n", offset, size);
> return;
> }
>
> @@ -357,7 +357,7 @@ static uint64_t xive_tm_raw_read(XiveTCTX *tctx, hwaddr
> offset, unsigned size)
> */
> if (size < 4 || !mask || ring_offset == TM_QW0_USER) {
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: invalid read access at TIMA @%"
> - HWADDR_PRIx"\n", offset);
> + HWADDR_PRIx" size %d\n", offset, size);
> return -1;
> }
>
> @@ -688,7 +688,7 @@ void xive_tctx_tm_write(XivePresenter *xptr, XiveTCTX
> *tctx, hwaddr offset,
> xto = xive_tm_find_op(tctx->xptr, offset, size, true);
> if (!xto) {
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: invalid write access at
> TIMA "
> - "@%"HWADDR_PRIx"\n", offset);
> + "@%"HWADDR_PRIx" size %d\n", offset, size);
> } else {
> xto->write_handler(xptr, tctx, offset, value, size);
> }
> @@ -727,7 +727,7 @@ uint64_t xive_tctx_tm_read(XivePresenter *xptr, XiveTCTX
> *tctx, hwaddr offset,
> xto = xive_tm_find_op(tctx->xptr, offset, size, false);
> if (!xto) {
> qemu_log_mask(LOG_GUEST_ERROR, "XIVE: invalid read access to
> TIMA"
> - "@%"HWADDR_PRIx"\n", offset);
> + "@%"HWADDR_PRIx" size %d\n", offset, size);
> return -1;
> }
> ret = xto->read_handler(xptr, tctx, offset, size);
