On Wed, May 14, 2025 at 09:23:58PM +1200, Michael Clark wrote: > On 5/14/25 20:17, Daniel P. Berrangé wrote: > > On Wed, May 14, 2025 at 07:39:27PM +1200, Michael Clark wrote: > > > diff --git a/disas/x86-core.c b/disas/x86-core.c > > > new file mode 100644 > > > index 000000000000..c4f7034e3420 > > > --- /dev/null > > > +++ b/disas/x86-core.c > > > @@ -0,0 +1,2716 @@ > > > +/* > > > + * Copyright (c) 2024-2025 Michael Clark > > > + * > > > + * SPDX-License-Identifier: MIT > > > > Note that we expect contributions to be under GPL-2.0-or-later, unless > > derived from existing code that forces use of a different license, which > > needs to be explained in the commit message > > okay no problem, I can do that. there is a freestanding external origin: > > https://github.com/michaeljclark/x86
IIUC, that would only apply to the x86-core.c file - the other files tagged with MIT look like thy were written just for QEMU inclusion. > I had a re-spin sitting in my queue for some time and I didn't have any > changes pending so I thought I would send it out. I would have folks > try it in private if they were considering merging it in the future. > one must balance the weight of future maintenance. I know that capstone > can be used to do the same so it is more of an FYI at this point. Ok With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
