On 09/05/2025 00.50, Zhuoying Cai wrote:
DIAGNOSE 320 is introduced to support certificate store facility,
which includes operations such as query certificate storage
information and provide certificates in the certificate store.

Currently, only subcode 0 is supported with this patch, which is
used to query a bitmap of which subcodes are supported.

Signed-off-by: Zhuoying Cai <zy...@linux.ibm.com>
---
  hw/s390x/ipl.h                 |  1 +
  include/hw/s390x/ipl/diag320.h | 17 +++++++++++++++
  target/s390x/diag.c            | 40 ++++++++++++++++++++++++++++++++++
  target/s390x/kvm/kvm.c         | 14 ++++++++++++
  target/s390x/s390x-internal.h  |  2 ++
  5 files changed, 74 insertions(+)
  create mode 100644 include/hw/s390x/ipl/diag320.h

diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h
index ac1f7517ea..d9c089928e 100644
--- a/hw/s390x/ipl.h
+++ b/hw/s390x/ipl.h
@@ -19,6 +19,7 @@
  #include "system/address-spaces.h"
  #include "system/memory.h"
  #include "hw/qdev-core.h"
+#include "hw/s390x/ipl/diag320.h"

Only adding a header #include without any other modifications to this file is a good indication that this include is not needed here. Unless you need this in later patches, please try to move it to the .c file(s) instead.

 Thanks,
  Thomas


Reply via email to