On Mon, May 12, 2025 at 02:01:35PM +0800, Li Zhijian wrote:
> Recently, we removed ipv6 restriction[0] from RDMA migration, add a
> test for it.
>
> [0]
> https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/
>
> Cc: Jack Wang <jinpu.w...@ionos.com>
> Cc: Michael R. Galaxy <mrgal...@nvidia.com>
> Cc: Peter Xu <pet...@redhat.com>
> Cc: Yu Zhang <yu.zh...@ionos.com>
> Reviewed-by: Jack Wang <jinpu.w...@ionos.com>
> Signed-off-by: Li Zhijian <lizhij...@fujitsu.com>
> ---
> V3:
> - skip unsupported rxe interfaces: lo, tun, tap
> - setup/reuse both ipv4 and ipv4 in one setup shot
It still fails the ipv6 test here...
# Running /x86_64/migration/precopy/rdma/plain/ipv6
# Using machine type: pc-q35-10.1
# starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-334248.sock
-qtest-log /dev/null -chardev socket,path=/tmp/qtest-334248.qmp,id=char0 -mon
char
dev=char0,mode=control -display none -audio none -accel kvm -accel tcg -machine
pc-q35-10.1, -name source,debug-threads=on -m 150M -serial file:/tmp/migration-
test-2TUX62/src_serial -drive
if=none,id=d0,file=/tmp/migration-test-2TUX62/bootsect,format=raw -device
ide-hd,drive=d0,secs=1,cyls=1,heads=1 -accel qtest
# starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-334248.sock
-qtest-log /dev/null -chardev socket,path=/tmp/qtest-334248.qmp,id=char0 -mon
char
dev=char0,mode=control -display none -audio none -accel kvm -accel tcg -machine
pc-q35-10.1, -name target,debug-threads=on -m 150M -serial file:/tmp/migration-
test-2TUX62/dest_serial -incoming
rdma:[fdd3:4fdc:97c9:ca4e:2837:28dd:1ec4:6b5a%wlp0s20f3]:29200 -drive
if=none,id=d0,file=/tmp/migration-test-2TUX62/bootsect,
format=raw -device ide-hd,drive=d0,secs=1,cyls=1,heads=1 -accel qtest
qemu-system-x86_64: -incoming
rdma:[fdd3:4fdc:97c9:ca4e:2837:28dd:1ec4:6b5a%wlp0s20f3]:29200: RDMA ERROR:
could not rdma_getaddrinfo address fdd3:4fdc:97c9:ca4e
:2837:28dd:1ec4:6b5a%wlp0s20f3
Broken pipe
../tests/qtest/libqtest.c:199: kill_qemu() tried to terminate QEMU process but
encountered exit status 1 (expected 0)
Aborted
Would below look right to you as a fix (I also adjusted a bool input):
diff --git a/tests/qtest/migration/precopy-tests.c
b/tests/qtest/migration/precopy-tests.c
index 1a67a9e2e4..a62d3c5378 100644
--- a/tests/qtest/migration/precopy-tests.c
+++ b/tests/qtest/migration/precopy-tests.c
@@ -197,12 +197,12 @@ static void __test_precopy_rdma_plain(bool ipv6)
static void test_precopy_rdma_plain(void)
{
- __test_precopy_rdma_plain(0);
+ __test_precopy_rdma_plain(false);
}
static void test_precopy_rdma_plain_ipv6(void)
{
- __test_precopy_rdma_plain(1);
+ __test_precopy_rdma_plain(true);
}
#endif
diff --git a/scripts/rdma-migration-helper.sh b/scripts/rdma-migration-helper.sh
index 404ce63a90..6ef61b9917 100755
--- a/scripts/rdma-migration-helper.sh
+++ b/scripts/rdma-migration-helper.sh
@@ -14,7 +14,7 @@ get_ipv6_addr() {
head -1 | tr -d '\n')
[ $? -eq 0 ] || return
- echo -n "[$ipv6%$1]"
+ echo -n "[$ipv6]"
}
With that the test runs. If it looks good to you I can queue it with that
squashed.
Thanks,
--
Peter Xu
