Re: [Qemu-devel] [PATCH] virtio-pci: add missing 'static'

[Blue Swirl]

On Sat, May 12, 2012 at 9:04 PM, Stefan Weil <s...@weilnetz.de> wrote:
> Am 12.05.2012 21:47, schrieb Blue Swirl:
>
>> There are no outside references to virtio_portio.
>> Add missing 'static' specifier.
>>
>> Signed-off-by: Blue Swirl <blauwir...@gmail.com>
>> ---
>> hw/virtio-pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index 4a4413d..8a931ce 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -491,7 +491,7 @@ static void virtio_pci_config_writel(void *opaque,
>> uint32_t addr, uint32_t val)
>
>
> line was wrapped
>
>
>> virtio_config_writel(proxy->vdev, addr, val);
>> }
>>
>> -const MemoryRegionPortio virtio_portio[] = {
>> +static const MemoryRegionPortio virtio_portio[] = {
>> { 0, 0x10000, 1, .write = virtio_pci_config_writeb, },
>> { 0, 0x10000, 2, .write = virtio_pci_config_writew, },
>> { 0, 0x10000, 4, .write = virtio_pci_config_writel, },
>
>
> terminating "---" and git version missing

Those are visible here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg01751.html

>
>
> Reviewed-by: Stefan Weil <s...@weilnetz.de>

Thanks for the review.

> The patch is fine, but your mailer reformats the patch:
> it cannot by applied with "git am" without manual corrections.
>
> Regards,
> Stefan W.
>
>