On 5/8/25 6:58 AM, Daniel P. Berrangé wrote:
This removes the TARGET_* conditions from all the CPU commands
that are conceptually target independent. Top level stubs are
provided to cope with targets which do not currently implement
all of the commands.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  qapi/machine-target.json              | 397 --------------------------
  qapi/machine.json                     | 363 +++++++++++++++++++++++
  stubs/meson.build                     |   2 +
  stubs/monitor-cpu-s390x.c             |  23 ++
  stubs/monitor-cpu.c                   |  21 ++
  target/arm/arm-qmp-cmds.c             |   2 +-
  target/i386/cpu-system.c              |   2 +-
  target/i386/cpu.c                     |   2 +-
  target/loongarch/loongarch-qmp-cmds.c |   2 +-
  target/mips/system/mips-qmp-cmds.c    |  12 +-
  target/ppc/ppc-qmp-cmds.c             |  12 +-
  target/riscv/riscv-qmp-cmds.c         |   2 +-
  target/s390x/cpu_models_system.c      |   2 +-
  13 files changed, 437 insertions(+), 405 deletions(-)
  create mode 100644 stubs/monitor-cpu-s390x.c
  create mode 100644 stubs/monitor-cpu.c


This sounds good to me, as long we are ok with having commands returning a "this command is not supported here" paradigm. I thought it was the complex case we were trying to deal with, precisely because we didn't want to introduce the "command here, but it returns an error" shell.

Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>


Reply via email to