On Tue, 8 Apr 2025 at 19:57, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > From: Joel Stanley <j...@jms.id.au> > > In commit 8fd2518ef2f8 ("hw: Centralize handling of -machine dumpdtb > option") the call to dump was moved with respect to the init of the > machine. This resulted in the device tree missing parts of the machine > description, depending on how they construct their device tree. > > The arm virt machine is missing some PSCI nodes, while the riscv one > is missing most of its content. > > Move the dump to after the notifiers have been run, allowing > virt_machine_done to be called and the device tree to be fully > populated. > > Fixes: 8fd2518ef2f8 ("hw: Centralize handling of -machine dumpdtb option") > Signed-off-by: Joel Stanley <j...@jms.id.au> > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> > Message-ID: <20250401041509.719153-1-j...@jms.id.au> > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
I just noticed that this (which is now commit 15a9fe6e35369d6e4 in master) didn't get tagged for stable. I think it's worth picking up in the 10.0.x branch, as the commit it's fixing is in the 10.0 release. thanks -- PMM