Re: [PATCH v3 02/19] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field

[Philippe Mathieu-Daudé]

On 7/5/25 08:23, Zhao Liu wrote:

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 3fffa4a3328..625889783ec 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1465,9 +1465,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
      }
      aml_append(dsdt, scope);

- if (pcmc->legacy_cpu_hotplug) {

-        build_legacy_cpu_hotplug_aml(dsdt, machine, pm->cpu_hp_io_base);
-    } else {
+    {

Why leave the {} here? for clarity?

Exactly, the diff-stat contains already more than 200 lines, too much to
my taste. If we de-indent this block, per our coding style we also need
to declare 'CPUHotplugFeatures opts' earlier. If you really want the
braces removed, I'd to it in a follow-up cleanup patch.

          CPUHotplugFeatures opts = {
              .acpi_1_compatible = true, .has_legacy_cphp = true,
              .smi_path = pm->smi_on_cpuhp ? "\\_SB.PCI0.SMI0.SMIC" : NULL,

Otherwise,

Reviewed-by: Zhao Liu <zhao1....@intel.com>

Thanks!