On Thu, Feb 13, 2025 at 02:26:11PM +0000, Peter Maydell wrote: > Date: Thu, 13 Feb 2025 14:26:11 +0000 > From: Peter Maydell <peter.mayd...@linaro.org> > Subject: [PATCH 2/4] target/i386: Use correct type for > get_float_exception_flags() values > X-Mailer: git-send-email 2.43.0 > > The softfloat get_float_exception_flags() function returns 'int', but > in various places in target/i386 we incorrectly store the returned > value into a uint8_t. This currently has no ill effects because i386 > doesn't care about any of the float_flag enum values above 0x40. > However, we want to start using float_flag_input_denormal_used, which > is 0x4000. > > Switch to using 'int' so that we can handle all the possible valid > float_flag_* values. This includes changing the return type of > save_exception_flags() and the argument to merge_exception_flags(). > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/i386/ops_sse.h | 16 +++---- > target/i386/tcg/fpu_helper.c | 82 ++++++++++++++++++------------------ > 2 files changed, 49 insertions(+), 49 deletions(-)
Reviewed-by: Zhao Liu <zhao1....@intel.com>
