On Tue, May 06, 2025 at 04:34:54PM +0200, Philippe Mathieu-Daudé wrote:
> Include "exec/target_page.h" to be able to compile HVF on x86_64:
>
> ../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier
> 'TARGET_PAGE_SIZE'
> uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
> ^
> ../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier
> 'TARGET_PAGE_SIZE'
> hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
>
> Fixes: 9c2ff9cdc9b ("exec/cpu-all: remove exec/target_page include")
> Reported-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
> Reported-by: Wei Liu <wei....@kernel.org>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> Message-Id: <20250425174310.70890-1-phi...@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
FYI Paolo merged a patch from me that does the same thing. My patch is
already in the master branch.
Wei.
> ---
> target/i386/hvf/hvf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
> index 99e37a33e50..b16fb066758 100644
> --- a/target/i386/hvf/hvf.c
> +++ b/target/i386/hvf/hvf.c
> @@ -50,6 +50,7 @@
> #include "qemu/error-report.h"
> #include "qemu/memalign.h"
> #include "qapi/error.h"
> +#include "exec/target_page.h"
> #include "migration/blocker.h"
>
> #include "system/hvf.h"
> --
> 2.47.1
>
