On 11 May 2012 13:16, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 10 May 2012 01:14, Andreas Färber <afaer...@suse.de> wrote: >> Also use cpu_reset() in place of cpu_state_reset(). >> >> Signed-off-by: Andreas Färber <afaer...@suse.de> > > The pxa2xx stuff is probably going to clash with the cp15 > rework, but I guess we'll sort that out when one or the > other of these series hits master. > > Acked-by: Peter Maydell <peter.mayd...@linaro.org>
Also looks good to me. > > (The stuff pxa2xx.c is doing to CPUARMState is a really > gross layering violation, incidentally.) The code reflects what the hardware is doing though. One could argue that if a hardware emulator divides things into layers where the real hardware violates those layers then the division is not fully correct. Cheers
