Re: [RFC 03/24] hw/i386/acpi-build: Fix build_append_notfication_callback typo

[Gustavo Romero]

Hi Eric,

On 4/28/25 07:25, Eric Auger wrote:

Rename build_append_notfication_callback into
build_append_notification_callback

Signed-off-by: Eric Auger <eric.au...@redhat.com>
---
  hw/i386/acpi-build.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 3fffa4a332..85c8a8566b 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -589,8 +589,8 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus 
*bus)
      }
  }

-static bool build_append_notfication_callback(Aml *parent_scope,

-                                              const PCIBus *bus)
+static bool build_append_notification_callback(Aml *parent_scope,
+                                               const PCIBus *bus)
  {
      Aml *method;
      PCIBus *sec;
@@ -604,7 +604,7 @@ static bool build_append_notfication_callback(Aml 
*parent_scope,
              continue;
          }
          nr_notifiers = nr_notifiers +
-                       build_append_notfication_callback(br_scope, sec);
+                       build_append_notification_callback(br_scope, sec);
          /*
           * add new child scope to parent
           * and keep track of bus that have PCNT,
@@ -1773,7 +1773,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
          PCIBus *b = PCI_HOST_BRIDGE(pci_host)->bus;

scope = aml_scope("\\_SB.PCI0");

-        has_pcnt = build_append_notfication_callback(scope, b);
+        has_pcnt = build_append_notification_callback(scope, b);
          if (has_pcnt) {
              aml_append(dsdt, scope);
          }

Reviewed-by: Gustavo Romero <gustavo.rom...@linaro.org>


Cheers,
Gustavo