On 5/4/25 18:51, Pierrick Bouvier wrote:
semihosting code needs to be included only if CONFIG_SEMIHOSTING is set.
However, this is a target configuration, so we need to apply it to the
libsystem libuser source sets.

Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  meson.build | 26 ++++++++++++++------------
  1 file changed, 14 insertions(+), 12 deletions(-)

Acked-by: Richard Henderson <richard.hender...@linaro.org>

I'm not quite sure how this is supposed to work. It appears this compiles everything in libsystem_ss, and then later selects whether the individual objects should be included in the link. This is fine for internal CONFIG like SEMIHOSTING, but won't be fine for a CONFIG that implies external dependencies like VNC.

I guess we can think about externals later, if it becomes an issue.


r~


Reply via email to