Am 10.05.2012 23:38, schrieb Peter Maydell: > On 10 May 2012 01:14, Andreas Färber <afaer...@suse.de> wrote: >> Fix tab indentations of comments, add braces, use cpu_reset(). >> >> Signed-off-by: Andreas Färber <afaer...@suse.de> >> --- >> hw/nseries.c | 6 +++--- >> hw/omap.h | 2 +- >> hw/omap1.c | 20 +++++++++++--------- >> hw/omap2.c | 8 ++++---- >> hw/omap_sx1.c | 2 +- >> hw/palm.c | 2 +- >> 6 files changed, 21 insertions(+), 19 deletions(-) > > There are some structs here which use the name 'cpu' for > a 'struct omap_mpu_state_s *', which leads to ugliness > like s->cpu->cpu->env. (We shouldn't be trying to fix that > here, just a passing comment.) > > Acked-by: Peter Maydell <peter.mayd...@linaro.org>
Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Now that we have qom-next, we are no longer limited to the concept of self-contained series so I can try to turn that into s->mpu->cpu->env the weekend. Not perfect either, but better distinguishable. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
