Hi Cédric, > -----Original Message----- > From: Cédric Le Goater <c...@kaod.org> > Sent: Wednesday, April 30, 2025 5:35 PM > To: Steven Lee <steven_...@aspeedtech.com>; Peter Maydell > <peter.mayd...@linaro.org>; Troy Lee <leet...@gmail.com>; Jamin Lin > <jamin_...@aspeedtech.com>; Andrew Jeffery > <and...@codeconstruct.com.au>; Joel Stanley <j...@jms.id.au>; open > list:ASPEED BMCs <qemu-...@nongnu.org>; open list:All patches CC here > <qemu-devel@nongnu.org> > Cc: Troy Lee <troy_...@aspeedtech.com>; long...@lenovo.com; Yunlin Tang > <yunlin.t...@aspeedtech.com> > Subject: Re: [PATCH v3 8/9] tests/function/aspeed: Add functional test for > AST2700FC > > On 4/29/25 11:18, Steven Lee wrote: > > Add functional test for AST2700-fc machine. > > > > Signed-off-by: Steven Lee <steven_...@aspeedtech.com> > > Change-Id: Ieced249cf471515a33f8f5f5386a2f58d431f2f9 > > ---> tests/functional/test_aarch64_ast2700fc.py | 137 > > ---> +++++++++++++++++++++ > > 1 file changed, 137 insertions(+) > > create mode 100755 tests/functional/test_aarch64_ast2700fc.py > > > > diff --git a/tests/functional/test_aarch64_ast2700fc.py > > b/tests/functional/test_aarch64_ast2700fc.py > > new file mode 100755 > > index 0000000000..f7b7907fde > > --- /dev/null > > +++ b/tests/functional/test_aarch64_ast2700fc.py > > @@ -0,0 +1,137 @@ > > +#!/usr/bin/env python3 > > +# > > +# Functional test that boots the AST2700 multi-SoCs with firmware # # > > +Copyright (C) 2025 ASPEED Technology Inc # # SPDX-License-Identifier: > > +GPL-2.0-or-later > > + > > +import os > > + > > +from qemu_test import QemuSystemTest, Asset from qemu_test import > > +wait_for_console_pattern from qemu_test import > > +exec_command_and_wait_for_pattern > > + > > + > > +class AST2700fcMachineSDK(QemuSystemTest): > > + ASSET_SDK_V905_AST2700 = Asset( > > + > 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.05/ast > 2700-default-obmc.tar.gz', > > + > > > +'c1f4496aec06743c812a6e9a1a18d032f34d62f3ddb6956e924fef62aa2046a5' > ) > > + > > + def do_test_aarch64_ast2700fc_ca35_start(self, image): > > + self.require_netdev('user') > > + self.vm.set_console() > > + self.vm.add_args('-drive', 'file=' + image + ',if=mtd,format=raw', > > + '-net', 'nic', '-net', 'user', '-snapshot') > > + > > + self.vm.launch() > > + > > + wait_for_console_pattern(self, 'U-Boot 2023.10') > > + wait_for_console_pattern(self, '## Loading kernel from FIT > Image') > > + wait_for_console_pattern(self, 'Starting kernel ...') > > + > > + def do_test_aarch64_ast2700fc_ssp_start(self): > > + > > + self.vm.shutdown() > > + self.vm.set_console(console_index=1) > > + self.vm.launch() > > + > > + def do_test_aarch64_ast2700fc_tsp_start(self): > > + self.vm.shutdown() > > + self.vm.set_console(console_index=2) > > + self.vm.launch() > > + > > + def start_ast2700fc_test(self, name): > > + ca35_core = 4 > > + uboot_size = os.path.getsize(self.scratch_file(name, > > + > 'u-boot-nodtb.bin')) > > + uboot_dtb_load_addr = hex(0x400000000 + uboot_size) > > + > > + load_images_list = [ > > + { > > + 'addr': '0x400000000', > > + 'file': self.scratch_file(name, > > + 'u-boot-nodtb.bin') > > + }, > > + { > > + 'addr': str(uboot_dtb_load_addr), > > + 'file': self.scratch_file(name, 'u-boot.dtb') > > + }, > > + { > > + 'addr': '0x430000000', > > + 'file': self.scratch_file(name, 'bl31.bin') > > + }, > > + { > > + 'addr': '0x430080000', > > + 'file': self.scratch_file(name, 'optee', > > + 'tee-raw.bin') > > + } > > + ] > > > Could this test be simplified with the recent addition of vbootrom support ? > > If so, you can use this branch : > > https://github.com/legoater/qemu/commits/aspeed-next/ > > Anyhow, >
Yes, I will simplify the test in the v4 patch series. Regards, Steven