Re: [PATCH v2 02/12] include/system/hvf: missing vaddr include

[Richard Henderson]

On 4/30/25 07:58, Pierrick Bouvier wrote:

On MacOS x86_64:
In file included from ../target/i386/hvf/x86_task.c:13:
/Users/runner/work/qemu/qemu/include/system/hvf.h:42:5: error: unknown type 
name 'vaddr'
     vaddr pc;
     ^
/Users/runner/work/qemu/qemu/include/system/hvf.h:43:5: error: unknown type 
name 'vaddr'
     vaddr saved_insn;
     ^
/Users/runner/work/qemu/qemu/include/system/hvf.h:45:5: error: type name 
requires a specifier or qualifier
     QTAILQ_ENTRY(hvf_sw_breakpoint) entry;
     ^
/Users/runner/work/qemu/qemu/include/system/hvf.h:45:18: error: a parameter 
list without types is only allowed in a function definition
     QTAILQ_ENTRY(hvf_sw_breakpoint) entry;
                  ^
/Users/runner/work/qemu/qemu/include/system/hvf.h:45:36: error: expected ';' at 
end of declaration list
     QTAILQ_ENTRY(hvf_sw_breakpoint) entry;

Reviewed-by: Philippe Mathieu-Daudé<phi...@linaro.org>
Signed-off-by: Pierrick Bouvier<pierrick.bouv...@linaro.org>
---
  include/system/hvf.h | 1 +
  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~