On Mon, Apr 28 2025, Eric Auger <eric.au...@redhat.com> wrote: > On 4/9/25 4:42 PM, Cornelia Huck wrote: >> From: Eric Auger <eric.au...@redhat.com> >> >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> >> Reviewed-by: Sebastian Ott <seb...@redhat.com> >> Signed-off-by: Eric Auger <eric.au...@redhat.com> >> Signed-off-by: Cornelia Huck <coh...@redhat.com> >> --- >> target/arm/cpu-features.h | 16 ++++++++-------- >> target/arm/cpu.c | 15 +++++---------- >> target/arm/cpu.h | 2 -- >> target/arm/cpu64.c | 4 ++-- >> target/arm/helper.c | 4 ++-- >> target/arm/hvf/hvf.c | 4 ++-- >> target/arm/internals.h | 6 +++--- >> target/arm/kvm.c | 12 +++++------- >> target/arm/tcg/cpu64.c | 33 +++++++++++++++++---------------- >> 9 files changed, 44 insertions(+), 52 deletions(-)
>> @@ -925,8 +925,9 @@ static void aarch64_a710_initfn(Object *obj) >> SET_IDREG(isar, ID_AA64PFR0, 0x1201111120111112ull); /* GIC filled in >> later */ >> SET_IDREG(isar, ID_AA64PFR1, 0x0000000000000221ull); >> SET_IDREG(isar, ID_AA64ZFR0, 0x0000110100110021ull); /* with Crypto */ >> - cpu->isar.id_aa64dfr0 = 0x000011f010305619ull; >> - cpu->isar.id_aa64dfr1 = 0; >> + SET_IDREG(isar, ID_AA64DFR0, 0x000011f010305619ull); >> + SET_IDREG(isar, ID_AA64DFR0, 0x000011f010305619ull); > this line is doubled. Indeed, fixing.
