On Mon, Apr 28 2025, Eric Auger <eric.au...@redhat.com> wrote: > Hi Connie, > > On 4/9/25 4:42 PM, Cornelia Huck wrote: >> From: Eric Auger <eric.au...@redhat.com> >> >> Also add kvm add accessors for storing host features into idregs. > nit: add kvm add?
Too much adding, will substract one add :) >> >> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> >> Reviewed-by: Sebastian Ott <seb...@redhat.com> >> Signed-off-by: Eric Auger <eric.au...@redhat.com> >> Signed-off-by: Cornelia Huck <coh...@redhat.com> >> --- >> target/arm/cpu-features.h | 57 ++++++++++++++++++++------------------- >> target/arm/cpu-sysregs.h | 4 +++ >> target/arm/cpu.c | 10 +++---- >> target/arm/cpu.h | 2 -- >> target/arm/cpu64.c | 8 +++--- >> target/arm/helper.c | 6 +++-- >> target/arm/hvf/hvf.c | 3 ++- >> target/arm/kvm.c | 30 ++++++++++++++++++--- >> target/arm/tcg/cpu64.c | 44 ++++++++++++++++++------------ >> 9 files changed, 101 insertions(+), 63 deletions(-) >> @@ -337,8 +361,7 @@ static bool >> kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf) >> ARM64_SYS_REG(3, 0, 0, 5, 0)); >> err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64dfr1, >> ARM64_SYS_REG(3, 0, 0, 5, 1)); >> - err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64isar0, > while at it you could add use fd in this other calls instead of > fdarray[2]. But this can be done later. Given that this series needs a respin anyway, might as well do that. >> - ARM64_SYS_REG(3, 0, 0, 6, 0)); >> + err |= get_host_cpu_reg(fd, ahcf, ID_AA64ISAR0_EL1_IDX); >> err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64isar1, >> ARM64_SYS_REG(3, 0, 0, 6, 1)); >> err |= read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64isar2,
