Hi Cedric,
> Cc: Troy Lee <troy_...@aspeedtech.com>; nabiheste...@google.com
> Subject: Re: [PATCH v7 1/1] pc-bios: Add AST27x0 vBootrom
>
> Hello Jamin,
>
> On 4/29/25 03:59, Jamin Lin wrote:
> > The boot ROM is a minimal implementation designed to load an AST27x0
> boot image.
> > Its source code is available at:
> > https://github.com/google/vbootrom
> > Commit id: d6e3386709b3e49322a94ffadc2aaab9944ab77b
> > Build Information:
> > ```
> > Build Date : Apr 29 2025 01:23:18
> > FW Version : git-d6e3386
> > ```
> >
> > Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>
> > Reviewed-by: Nabih Estefan <nabiheste...@google.com>
> > Reviewed-by: Cédric Le Goater <c...@redhat.com>
> > Tested-by: Nabih Estefan <nabiheste...@google.com>
> > ---
> > MAINTAINERS | 1 +
> > pc-bios/README | 6 ++++++
> > pc-bios/ast27x0_bootrom.bin | Bin 0 -> 15552 bytes
> > pc-bios/meson.build | 1 +
> > 4 files changed, 8 insertions(+)
> > create mode 100644 pc-bios/ast27x0_bootrom.bin
>
> [ ... ]
>
> > index 34d6616c32..83998f6071 100644
> > --- a/pc-bios/meson.build
> > +++ b/pc-bios/meson.build
> > @@ -84,6 +84,7 @@ blobs = [
> > 'npcm8xx_bootrom.bin',
> > 'vof.bin',
> > 'vof-nvram.bin',
> > + 'ast27x0_bootrom.bin',
>
> I think this list should be kept in alphabetic order. Could you resend please
> ?
>
OK
> Thanks,
>
> C.
>
>
>
>
> > ]
> >
> > dtc = find_program('dtc', required: false)
