25.04.2025 20:52, Kevin Wolf wrote:
From: Denis Rastyogin <ger...@altlinux.org>This error was discovered by fuzzing qemu-img. Currently, running `qemu-img bench -d 0` in img_bench is allowed, which is a pointless operation and causes qemu-img to hang. Signed-off-by: Denis Rastyogin <ger...@altlinux.org> Message-ID: <20250327162423.25154-5-ger...@altlinux.org> Reviewed-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 2044c22a4c..76ac5d3028 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4571,7 +4571,7 @@ static int img_bench(int argc, char **argv) { unsigned long res;- if (qemu_strtoul(optarg, NULL, 0, &res) < 0 || res > INT_MAX) {+ if (qemu_strtoul(optarg, NULL, 0, &res) <= 0 || res > INT_MAX) { error_report("Invalid queue depth specified"); return 1; }
FWIW, it's been covered by my qemu-img options patches for way over a year. /mjt
