On 25/04/2025 14.17, Daniel P. Berrangé via wrote:
Currently valgrind debugging support for coroutine stacks is enabled
unconditionally when valgrind/valgrind.h is found. There is no way
to disable valgrind support if valgrind.h is present in the build env.

This is bad for distros, as an dependency far down the chain may cause
valgrind.h to become installed, inadvertantly enabling QEMU's valgrind
debugging support. It also means if a distro wants valgrind support
there is no way to mandate this.

The solution is to add a 'valgrind' build feature to meson and thus
configure script.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  meson.build                   | 13 ++++++++++++-
  meson_options.txt             |  2 ++
  scripts/meson-buildoptions.sh |  3 +++
  3 files changed, 17 insertions(+), 1 deletion(-)

Reviewed-by: Thomas Huth <th...@redhat.com>


Reply via email to