On Fri, Apr 25, 2025 at 08:14:13AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 06, 2025 at 03:16:26PM +0900, Akihiko Odaki wrote: > > This series was spun off from: > > "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" > > (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aab...@daynix.com/) > > > > Some features are not always available with vhost. Legacy features are > > not available with vp_vdpa in particular. virtio devices used to disable > > them when not available even if the corresponding properties were > > explicitly set to "on". > > > > QEMU already has OnOffAuto type, which includes the "auto" value to let > > it automatically decide the effective value. Convert feature properties > > to OnOffAuto and set them "auto" by default to utilize it. This allows > > QEMU to report an error if they are set "on" and the corresponding > > features are not available. > > > > Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> > > > Marcus, Paolo, Daniel, Eduardo, any feedback on the QOM bits?
I've said on every previous version that I don't think we should be changing OnOffAuto to secretly accept bool values. That is bypassing QAPI schema definitions with a special code hack. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
