On Thu, Apr 24, 2025 at 06:32:13PM +0200, Cédric Le Goater wrote:

> > @@ -2250,6 +2251,10 @@ bool memory_get_xlat_addr(IOMMUTLBEntry *iotlb, void 
> > **vaddr,
> >           *read_only = !writable || mr->readonly;
> >       }
> > +    if (mrp != NULL) {
> > +        *mrp = mr;
> > +    }
> > +
> >       return true;
> >   }
> 
> Is everyone OK with adding an extra in/out parameter to 
> memory_get_xlat_addr() ?
> Should we take a ref on the region ?
> 
> I think this change should be proposed in its own patch as done in the 
> previous
> series and by Steve for live update.

Yep, I left this one last as I think it's best picked up by someone who
understands this a lot better than me!

regards
john

Reply via email to