Re: [PATCH v6 1/6] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region

[Cédric Le Goater]

On 4/24/25 09:51, Jamin Lin wrote:

Introduce a new vbootrom memory region. The region is mapped at address
"0x00000000" and has a size of 128KB, identical to the SRAM region size.
This memory region is intended for loading a vbootrom image file as part of the
boot process.

The vbootrom registered in the SoC's address space using the ASPEED_DEV_VBOOTROM
index.

Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>
Reviewed-by: Nabih Estefan <nabiheste...@google.com>
Tested-by: Nabih Estefan <nabiheste...@google.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  include/hw/arm/aspeed_soc.h | 2 ++
  hw/arm/aspeed_ast27x0.c     | 9 +++++++++
  2 files changed, 11 insertions(+)

diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index f069d17d16..b4b23d693d 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -59,6 +59,7 @@ struct AspeedSoCState {
      MemoryRegion sram;
      MemoryRegion spi_boot_container;
      MemoryRegion spi_boot;
+    MemoryRegion vbootrom;
      AddressSpace dram_as;
      AspeedRtcState rtc;
      AspeedTimerCtrlState timerctrl;
@@ -169,6 +170,7 @@ struct AspeedSoCClass {
  const char *aspeed_soc_cpu_type(AspeedSoCClass *sc);

enum {

+    ASPEED_DEV_VBOOTROM,
      ASPEED_DEV_SPI_BOOT,
      ASPEED_DEV_IOMEM,
      ASPEED_DEV_UART0,
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index b05ed75ff4..968dfa5526 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -24,6 +24,7 @@
  #include "qemu/log.h"

static const hwaddr aspeed_soc_ast2700_memmap[] = {

+    [ASPEED_DEV_VBOOTROM]  =  0x00000000,
      [ASPEED_DEV_SRAM]      =  0x10000000,
      [ASPEED_DEV_HACE]      =  0x12070000,
      [ASPEED_DEV_EMMC]      =  0x12090000,
@@ -657,6 +658,14 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, 
Error **errp)
      memory_region_add_subregion(s->memory,
                                  sc->memmap[ASPEED_DEV_SRAM], &s->sram);

+ /* VBOOTROM */

+    if (!memory_region_init_ram(&s->vbootrom, OBJECT(s), "aspeed.vbootrom",
+                                0x20000, errp)) {
+        return;
+    }
+    memory_region_add_subregion(s->memory,
+                                sc->memmap[ASPEED_DEV_VBOOTROM], &s->vbootrom);
+
      /* SCU */
      if (!sysbus_realize(SYS_BUS_DEVICE(&s->scu), errp)) {
          return;