On 23/4/25 23:07, Richard Henderson wrote:
On 4/23/25 03:03, Philippe Mathieu-Daudé wrote:
Hi Richard,

On 22/4/25 21:26, Richard Henderson wrote:
While we're renaming things, don't modify addr; save it for
reuse in the qatomic_set.  Compute the host address into a
new local variable.

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  accel/tcg/cputlb.c | 20 ++++++++++----------
  1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 10090067f7..5df98d93d0 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -882,18 +882,16 @@ void tlb_unprotect_code(ram_addr_t ram_addr)
   *
   * Called with tlb_c.lock held.
   */
-static void tlb_reset_dirty_range_locked(CPUTLBEntry *tlb_entry,
+static void tlb_reset_dirty_range_locked(CPUTLBEntryFull *full, CPUTLBEntry *ent,                                            uintptr_t start, uintptr_t length)
  {
-    uintptr_t addr = tlb_entry->addr_write;
+    const uintptr_t addr = ent->addr_write;

Can we introduce 'int flags' here, and add the CPUTLBEntryFull
argument in the following patch?

What 'int flags'?

Whatever please ignore.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to