Re: [PATCH v5 10/11] tests/functional/aspeed: Add to test vbootrom for AST2700

[Cédric Le Goater]

On 4/23/25 09:23, Jamin Lin wrote:

Add the AST2700 functional test to boot using the vbootrom image
instead of manually loading boot components with -device loader.
The boot ROM binary is now passed via the
-bios option, using the image located in pc-bios/ast27x0_bootrom.bin.

Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  tests/functional/test_aarch64_aspeed.py | 26 +++++++++++++++++++++++++
  1 file changed, 26 insertions(+)

diff --git a/tests/functional/test_aarch64_aspeed.py 
b/tests/functional/test_aarch64_aspeed.py
index 2f04655b60..34ddfa852c 100755
--- a/tests/functional/test_aarch64_aspeed.py
+++ b/tests/functional/test_aarch64_aspeed.py
@@ -25,6 +25,18 @@ def do_test_aarch64_aspeed_sdk_start(self, image):

self.vm.launch() + def verify_vbootrom_firmware_flow(self):

+        wait_for_console_pattern(self, 'Found valid FIT image')
+        wait_for_console_pattern(self, '[uboot] loading')
+        wait_for_console_pattern(self, 'done')
+        wait_for_console_pattern(self, '[fdt] loading')
+        wait_for_console_pattern(self, 'done')
+        wait_for_console_pattern(self, '[tee] loading')
+        wait_for_console_pattern(self, 'done')
+        wait_for_console_pattern(self, '[atf] loading')
+        wait_for_console_pattern(self, 'done')
+        wait_for_console_pattern(self, 'Jumping to BL31 (Trusted Firmware-A)')
+
      def verify_openbmc_boot_and_login(self, name):
          wait_for_console_pattern(self, 'U-Boot 2023.10')
          wait_for_console_pattern(self, '## Loading kernel from FIT Image')
@@ -94,6 +106,11 @@ def start_ast2700_test(self, name):
          self.do_test_aarch64_aspeed_sdk_start(
              self.scratch_file(name, 'image-bmc'))

+ def start_ast2700_test_vbootrom(self, name):

+        self.vm.add_args('-bios', 'ast27x0_bootrom.bin')
+        self.do_test_aarch64_aspeed_sdk_start(
+                self.scratch_file(name, 'image-bmc'))
+
      def test_aarch64_ast2700_evb_sdk_v09_06(self):
          self.set_machine('ast2700-evb')

@@ -110,5 +127,14 @@ def test_aarch64_ast2700a1_evb_sdk_v09_06(self):

          self.verify_openbmc_boot_and_login('ast2700-default')
          self.do_ast2700_i2c_test()

+ def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_06(self):

+        self.set_machine('ast2700a1-evb')
+
+        self.archive_extract(self.ASSET_SDK_V906_AST2700A1)
+        self.start_ast2700_test_vbootrom('ast2700-default')
+        self.verify_vbootrom_firmware_flow()
+        self.verify_openbmc_boot_and_login('ast2700-default')
+        self.do_ast2700_i2c_test()
+
  if __name__ == '__main__':
      QemuSystemTest.main()