On 4/23/25 04:02, Philippe Mathieu-Daudé wrote:
On 22/4/25 21:27, Richard Henderson wrote:
From: Pierrick Bouvier <pierrick.bouv...@linaro.org>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Message-ID: <20250325045915.994760-16-pierrick.bouv...@linaro.org>
---
include/exec/cpu-all.h | 25 -------------------------
include/hw/core/cpu.h | 2 +-
include/qemu/bswap.h | 2 +-
target/alpha/cpu.h | 2 --
target/arm/cpu.h | 2 --
target/avr/cpu.h | 2 --
target/hexagon/cpu.h | 2 --
target/hppa/cpu.h | 2 --
target/i386/cpu.h | 1 -
target/loongarch/cpu.h | 2 --
target/m68k/cpu.h | 2 --
target/microblaze/cpu.h | 2 --
target/mips/cpu.h | 2 --
target/openrisc/cpu.h | 2 --
target/ppc/cpu.h | 2 --
target/riscv/cpu.h | 2 --
target/rx/cpu.h | 2 --
target/s390x/cpu.h | 2 --
target/sh4/cpu.h | 2 --
target/sparc/cpu.h | 2 --
target/tricore/cpu.h | 2 --
target/xtensa/cpu.h | 2 --
accel/tcg/cpu-exec.c | 1 -
hw/hyperv/hyperv.c | 1 -
semihosting/uaccess.c | 1 -
tcg/tcg-op-ldst.c | 2 +-
26 files changed, 3 insertions(+), 68 deletions(-)
delete mode 100644 include/exec/cpu-all.h
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index b915835bea..8782056ae4 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -206,7 +206,7 @@ CPU_CONVERT(le, 64, uint64_t)
* (except for byte accesses, which have no endian infix).
*
* The target endian accessors are obviously only available to source
- * files which are built per-target; they are defined in cpu-all.h.
+ * files which are built per-target; they are defined in system/memory.h.
IIUC in patch #2 "exec/tswap: implement {ld,st}.*_p as functions instead
of macros" you moved them to "exec/tswap.h", not "system/memory.h".
You're right, the comment does not make sense, especially that now we
can include those in common file too (so they are not accessible only in
per-target code). I just did a mass replace of cpu-all.
If someone is looking for where their implementation is, they can grep
it or use their autocompletion to reach it.
@Richard, could you please remove those two comments line?
Thanks,
Pierrick
Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
