On 4/23/25 15:33, Cédric Le Goater wrote:
On 4/23/25 14:05, Philippe Mathieu-Daudé wrote:
Convert AspeedI2CClass::gap to plain unsigned, using '0'
as "no gap" to avoid the followin UBSan warnings:
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../hw/i2c/aspeed_i2c.c:1559:16
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../hw/i2c/aspeed_i2c.c:1583:16
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../hw/i2c/aspeed_i2c.c:1608:16
hw/i2c/aspeed_i2c.c:1608:16: runtime error: implicit conversion from type
'int' of value
-1 (32-bit, signed) to type 'uint8_t' (aka
'unsigned char')
changed the value to 255 (8-bit, unsigned)
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Looks fine.
nope. It's breaking make check :
ERROR:../tests/qtest/tpm-tis-i2c-test.c:104:tpm_tis_i2c_test_basic: assertion
failed (access == TPM_TIS_ACCESS_TPM_REG_VALID_STS |
TPM_TIS_ACCESS_TPM_ESTABLISHMENT): (255 == 129)
Unexpected error in qio_channel_socket_writev() at ../io/channel-socket.c:622:
/home/legoater/work/qemu/qemu-aspeed.git/build/tests/qtest/tpm-tis-i2c-test:
Unable to write to socket: Bad file descriptorqemu-system-aarch64:
tpm-emulator: Could not cleanly shutdown the TPM: Interrupted system call
C.
