On 22/4/25 21:26, Richard Henderson wrote:
Poison CONFIG_USER_ONLY and CONFIG_SOFTMMU unless
the compilation unit is in specific_ss, libuser_ss,
or libsystem_ss.  This is intended to prevent files
being incorrectly added to common_ss.

Remove #ifndef CONFIG_USER_ONLY / #error / #endif blocks.
All they do is trigger the poison error.

Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  include/exec/poison.h                       | 5 +++++
  include/hw/hw.h                             | 4 ----
  include/system/confidential-guest-support.h | 4 ----
  include/system/replay.h                     | 4 ----
  include/system/xen.h                        | 4 ----
  meson.build                                 | 6 ++++--
  6 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/include/exec/poison.h b/include/exec/poison.h
index 2c151fd1e0..4180a5a489 100644
--- a/include/exec/poison.h
+++ b/include/exec/poison.h
@@ -66,4 +66,9 @@
  #pragma GCC poison CONFIG_WHPX
  #pragma GCC poison CONFIG_XEN
+#ifndef COMPILING_SYSTEM_VS_USER
+#pragma GCC poison CONFIG_USER_ONLY
+#pragma GCC poison CONFIG_SOFTMMU
+#endif

Nice.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to