Philippe Mathieu-Daudé <phi...@linaro.org> writes:
> On 22/4/25 07:55, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <phi...@linaro.org> writes:
>>
>>> The QAPI-generated 'TargetInfo' structure name is only used
>>> in a single file. We want to heavily use another structure
>>> similarly named. Rename the QAPI one, since structure names
>>> are not part of the public API.
>>>
>>> Suggested-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
>>> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>>> Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
>>> ---
>>> qapi/machine.json | 12 ++++++------
>>> hw/core/machine-qmp-cmds.c | 4 ++--
>>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/qapi/machine.json b/qapi/machine.json
>>> index a6b8795b09e..3246212f048 100644
>>> --- a/qapi/machine.json
>>> +++ b/qapi/machine.json
>>> @@ -275,15 +275,15 @@
>>> { 'command': 'query-current-machine', 'returns': 'CurrentMachineParams' }
>>>
>>> ##
>>> -# @TargetInfo:
>>> +# @BinaryTargetInfo:
>>> #
>>> -# Information describing the QEMU target.
>>> +# Information describing the QEMU binary target.
>>
>> What's "the QEMU binary target"? The QEMU binary's target?
>
> For me 'qemu-system-aarch64' is a QEMU binary,
Makes sense to me.
> but for Pierrick and
> Richard it is the QEMU target,
Make about as much sense to me as calling my /usr/bin/gcc "the GNU C
compiler target", i.e. none. It's the GNU C compiler targeting x86_64.
> so I merged both names ¯\_(ツ)_/¯
If it gets your patch merged...
> This structure describes the static target configuration built into
> a binary, i.e. TARGET_NAME=aarch64, TARGET_BIG_ENDIAN=false.
>
> For the forthcoming single/heterogeneous binary, we don't have a
> particular restricted configuration in the binary.
>
> What about "Information describing the QEMU target configuration
> built in a binary."?
That's better. Here's my try: "Information on the target configuration
built into the QEMU binary."
>> From the QMP user's point of view, perhaps "the QEMU process's target"
>> would make more sense.
>
> So maybe ProcessTargetInfo is a better structure name.
QemuTargetInfo would sidestep binary vs. process.
> For heterogeneous target I suppose we'll return SYS_EMU_TARGET_HETERO
> and we'll provide new QMP commands, possibly returning array of
> ProcessTargetInfo.
[...]
