Hi On Tue, Apr 22, 2025 at 11:03 AM Dietmar Maurer <diet...@proxmox.com> wrote: > > > > On 22.4.2025 08:39 CEST Marc-André Lureau <marcandre.lur...@gmail.com> > > wrote: > > > > > > Hi > > > > On Tue, Apr 22, 2025 at 10:37 AM Dietmar Maurer <diet...@proxmox.com> wrote: > > > > > > > On Fri, Apr 18, 2025 at 3:30 PM Dietmar Maurer <diet...@proxmox.com> > > > > wrote: > > > > > > > > > > Some encoders can hang indefinetly (i.e. nvh264enc) if > > > > > > > > indefinitely > > > > > > > > > the pipeline is not stopped before it is destroyed > > > > > (Observed on Debian bookworm). > > > > > > > > but why do you need the extra shutdown notifier? > > > > > > Because Qemu does not close open VNC connections on shutdown. > > > and if the VNC connection is open, the h264 pipeline is still active, > > > which cause the Qemu process to hang (CTRL-C does not stop it, only kill > > > -9) > > > > Given that h264 code depends on VNC state, can you make VNC > > close/clean the connection instead? > > For all open VNC connections? >
Yes, we should have a cleanup path instead of shutdown notifiers. -- Marc-André Lureau
