On 4/14/25 23:43, Philippe Mathieu-Daudé wrote:
+static inline uint8_t host_pci_ldub_p(const void *ioaddr)Is it really worth inlining?+{ + uint8_t ret = 0; +#ifdef __s390x__ + ret = s390x_pci_mmio_read_8(ioaddr); +#else + ret = ldub_he_p(ioaddr); +#endif
Since the non-s390x path is a single byte load, yes, it probably is worth inlining. r~