On 4/11/25 8:48 PM, Eric Blake wrote: > On Fri, Sep 13, 2024 at 07:39:35PM +0300, Andrey Drobyshev wrote: >> Move the definition from iotests/250 to common.rc. This is used to >> detect real disk usage of sparse files. In particular, we want to use >> it for checking subclusters-based discards. >> >> Signed-off-by: Andrey Drobyshev <andrey.drobys...@virtuozzo.com> >> Reviewed-by: Alexander Ivanov <alexander.iva...@virtuozzo.com> >> Reviewed-by: Alberto Garcia <be...@igalia.com> >> --- >> tests/qemu-iotests/250 | 5 ----- >> tests/qemu-iotests/common.rc | 6 ++++++ >> 2 files changed, 6 insertions(+), 5 deletions(-) > > Hmm - I should probably refactor my recent blockdev-mirror sparse test > to take advantage of this as well. > https://lists.gnu.org/archive/html/qemu-devel/2025-04/msg01799.html >
Sure, though it'd apparently be easier to use when this series gets finally merged :) It's been hanging out there for quite a while now, and it's been neither rejected, nor fully reviewed: v1: https://lore.kernel.org/all/20231020215622.789260-1-andrey.drobys...@virtuozzo.com/ v2: https://lore.kernel.org/all/20240513063203.113911-1-andrey.drobys...@virtuozzo.com/ v3: https://lore.kernel.org/all/20240913163942.423050-1-andrey.drobys...@virtuozzo.com/ Could somebody please take yet another look at this? Maybe @Hanna, @Kevin, @Alberto? Of course I might need to rebase it to the latest master. Andrey
