>-----Original Message----- >From: Cédric Le Goater <c...@redhat.com> >Subject: Re: [PATCH for-10.1 v2 11/37] vfio: Introduce new files for VFIORegion >definitions and declarations > >On 3/27/25 10:37, Duan, Zhenzhong wrote: >> >> >>> -----Original Message----- >>> From: Cédric Le Goater <c...@redhat.com> >>> Subject: [PATCH for-10.1 v2 11/37] vfio: Introduce new files for VFIORegion >>> definitions and declarations ... >3f002252acfb7ac809107c99bdbdbaf66d56a50d..4591ec68da877b307f43ea1a83 >>> 0c315721b57e9e 100644 >>> --- a/hw/vfio/pci-quirks.c >>> +++ b/hw/vfio/pci-quirks.c >>> @@ -26,6 +26,7 @@ >>> #include "hw/qdev-properties.h" >>> #include "pci.h" >>> #include "pci-quirks.h" >>> +#include "hw/vfio/vfio-region.h" >> >> This looks unnecessary as pci.h already include it, > >It doesn't but it should. I will include "hw/vfio/vfio-region.h" >in "pci.h" and remove it from "pci-quirks.c" and "pci.c" instead.
hw/vfio/pci.h includes hw/vfio/vfio-display.h which further includes include/hw/vfio/vfio-region.h, build pass if only remove #include on my env. Thanks Zhenzhong
