Hi Zhao,
On 3/21/25 11:43 AM, Zhao Liu wrote:
Hi Shaoqin,
Thank you very much for testing!
I tried your series on ARM64, but it reports error at compile time, here is
the error output:
qapi/kvm.json:59:Unexpected indentation.
I guess this is caused by my invalid format and sphinx complains that,
as Markus figured out :-(
What about the following change?
diff --git a/qapi/kvm.json b/qapi/kvm.json
index 31447dfeffb0..b383dfd9a788 100644
--- a/qapi/kvm.json
+++ b/qapi/kvm.json
@@ -54,11 +54,6 @@
##
# @KVMPMUX86DefalutEvent:
#
-# x86 PMU event encoding with select and umask.
-# raw_event = ((select & 0xf00UL) << 24) | \
-# (select) & 0xff) | \
-# ((umask) & 0xff) << 8)
-#
# @select: x86 PMU event select field, which is a 12-bit unsigned
# number.
#
This doesn't work for me.
But this works on ARM:
-# (select) & 0xff) | \
-# ((umask) & 0xff) << 8)
+# (select) & 0xff) | \
+# ((umask) & 0xff) << 8)
While I compiled it on x86, everything is ok. Could you please check why it
failed on ARM64?
Maybe your Arm64 environment doesn't have sphinx_rtd_theme?
You can check it by:
python3 -m pip show sphinx_rtd_theme
By the mean time, I will review and test this series.
Thank you again! I also plan to refresh v3, in maybe 1 or 2 weeks.
Ok, Waiting for your new respin. :)
Thanks,
Shaoqin
Best Regards,
Zhao
--
Shaoqin
