On 5/4/25 03:03, Pierrick Bouvier wrote:
On 4/4/25 14:53, Philippe Mathieu-Daudé wrote:
On 4/4/25 20:20, Pierrick Bouvier wrote:
On 4/3/25 16:57, Philippe Mathieu-Daudé wrote:
We would like to get rid of '-I target/$ARCH/' in the CPPFLAGS.

While this change is correct, this is not strictly needed.
With the current approach, using a set of common files per architecture,
we can rely on this include to be present, and it does not block from
having common files.

Indeed, I rebased this commit from my heterogeneous branch.

I'll keeping carrying / rebasing it for various months, trying to
remember to not keeping posting it.

Or alternatively I'll post it in a separate "cleanup series", not
mentioning single-binary or heterogeneous emulation.


My point was not "please post that later", but simply to say those changes are not needed, now or in the future. We can have a specific include path for various files without compromising the single binary/heterogenenous, as long as we compile it only once.

Incorrect, this is required for heterogenenous emulation.

So we don't need to remove cpu.h inclusion in target related code.

Use the full path to "cpu.h": "target/arm/cpu.h".

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
   include/hw/arm/digic.h      | 2 +-
   include/hw/arm/fsl-imx6.h   | 2 +-
   include/hw/arm/fsl-imx6ul.h | 2 +-
   include/hw/arm/fsl-imx7.h   | 2 +-
   include/hw/arm/fsl-imx8mp.h | 2 +-
   5 files changed, 5 insertions(+), 5 deletions(-)




Reply via email to